Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Icon] Restore rotate function #305

Closed
luciob opened this issue May 2, 2023 · 1 comment · Fixed by #372
Closed

[Icon] Restore rotate function #305

luciob opened this issue May 2, 2023 · 1 comment · Fixed by #372
Assignees
@CrisGrud
Labels
bug Something isn't working released
Milestone
React 18 support

Comments

@luciob
Copy link
Member

luciob commented May 2, 2023

Restore rotate prop functioning on Icon component.
It has been temporarily put apart due to emotion support of keyframes which doesn't seem to be so easy when chained with conditionals. This needs to be understood opening a ticket on emotion / mui 5 repo.
@luciob luciob added enhancement New feature or request beta Issue related only to beta tag labels May 2, 2023
@luciob luciob added this to the React 18 support on beta milestone May 2, 2023
@luciob luciob self-assigned this May 2, 2023
@luciob luciob added bug Something isn't working and removed enhancement New feature or request labels May 3, 2023
@luciob luciob removed their assignment May 3, 2023
@luciob luciob removed the beta Issue related only to beta tag label Jun 5, 2023
CrisGrud pushed a commit that referenced this issue Jan 11, 2024
fix: 🐛 [Icon] Fixed rotate function
3269738 
✅ Closes: #305
@CrisGrud CrisGrud mentioned this issue Jan 11, 2024
Merged
@CrisGrud CrisGrud linked a pull request Jan 11, 2024 that will close this issue
[Icon] Fixed rotate function #372
Merged
CrisGrud pushed a commit that referenced this issue Jan 11, 2024
test: 💍 Update snapshot
fbabb03 
✅ Closes: #305
CrisGrud pushed a commit that referenced this issue Jan 11, 2024
test: 💍 Update test
903eb56 
✅ Closes: #305
CrisGrud pushed a commit that referenced this issue Jan 11, 2024
test: 💍 [Card] update test
6387b7a 
✅ Closes: #305
CrisGrud pushed a commit that referenced this issue Jan 11, 2024
test: 💍 [Tabs] test migration
eb556f0 
✅ Closes: #305
CrisGrud pushed a commit that referenced this issue Jan 11, 2024
test: 💍 final snapshot update
f1f18a6 
✅ Closes: #305
melfore-devops pushed a commit that referenced this issue Jan 11, 2024
@semantic-release-bot
chore(release): 9.9.4 [skip ci]
5f86640 
## [9.9.4](v9.9.3...v9.9.4) (2024-01-11)

### Bug Fixes

* 🐛 [Icon] Fixed rotate function ([3269738](3269738)), closes [#305](#305)
@melfore-devops
Copy link
Collaborator

🎉 This issue has been resolved in version 9.9.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CrisGrud CrisGrud

Labels
bug Something isn't working released
Projects
None yet
Milestone
React 18 support
Development

Successfully merging a pull request may close this issue.

[Icon] Fixed rotate function melfore/mosaic
3 participants
@luciob @CrisGrud @melfore-devops