Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Refactor and expose component #246

Closed
luciob opened this issue Apr 5, 2022 · 1 comment · Fixed by #323
Closed

[Menu] Refactor and expose component #246

luciob opened this issue Apr 5, 2022 · 1 comment · Fixed by #323
Assignees
@CrisGrud
Labels
enhancement New feature or request released

Comments

@luciob
Copy link
Member

luciob commented Apr 5, 2022

Rework done in #244 for AppBar must be applied to Menu as well.
Export component for external standalone usage.
Support locale of label property, see TODO in AppBar/index.tsx:

  // TODO: review for localized hoc, adding "user.items.label"

This gives the chance to remove deprecated props from AppBar component.
@luciob luciob self-assigned this Apr 5, 2022
@luciob luciob changed the title Refactor and expose Menu component [Menu] Refactor and expose component May 3, 2023
@luciob luciob added the enhancement New feature or request label May 3, 2023
@luciob luciob removed their assignment May 3, 2023
@luciob luciob mentioned this issue Aug 28, 2023
Closed
CrisGrud pushed a commit that referenced this issue Aug 29, 2023
feat: 🎸 [Menu] Added component
3880865 
✅ Closes: #246
@CrisGrud CrisGrud linked a pull request Aug 29, 2023 that will close this issue
[Menu] Added component #323
Merged
@CrisGrud CrisGrud mentioned this issue Aug 29, 2023
Merged
luciob pushed a commit that referenced this issue Aug 29, 2023
@semantic-release-bot
chore(release): 8.6.0 [skip ci]
e2d5cb7 
# [8.6.0](v8.5.0...v8.6.0) (2023-08-29)

### Features

* 🎸 [Menu] Added component ([3880865](3880865)), closes [#246](#246)
@luciob
Copy link
Member Author

luciob commented Aug 29, 2023

🎉 This issue has been resolved in version 8.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CrisGrud CrisGrud

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Menu] Added component melfore/mosaic
2 participants
@luciob @CrisGrud