fix: tests for Jest 27 #10
Conversation
anmonteiro
force-pushed
the
anmonteiro/fix-tests-jest27
branch
from
ae305d2
to
c1a25be
Compare
There was a problem hiding this comment.
@anmonteiro Thanks, sorry I missed this. Maybe worth adding an entry in the changelog?
| [@@@mel.config { flags = [| "--preamble"; | ||
| {| | ||
| /** | ||
| * @jest-environment jsdom |
There was a problem hiding this comment.
Should this be added in jest.config.js? Or is it beneficial to keep it here for more accuracy?
package.json
Outdated
| "@testing-library/jest-dom": "^6.4.1", | ||
| "jest": "^29.7.0", | ||
| "jest-environment-jsdom": "^29.7.0", | ||
| "jsdom": "^24.0.0" |
There was a problem hiding this comment.
I don't think this is needed because jest-environment-jsdom already depends on it: https://www.npmjs.com/package/jest-environment-jsdom?activeTab=dependencies.
However, we could update the opam depext field to reflect this new dependency.
* main: comment snapshotting for now fix call to npm-check-deps add ci chore: require dune 3.9 to pick up `melange.emit` fix from 3.8.2 chore: add changelog for 0.1.1 Revert "fix(opam): require melange v3"
jchavarri
force-pushed
the
anmonteiro/fix-tests-jest27
branch
from
a231617
to
dc60420
Compare
|
@anmonteiro Thanks, I'm gonna merge this as it unblocks the work in #12. The nix build is failing for some reason, but now that there's opam pipeline at least we can keep checking things work. Could you please help fix it? 🙏 |
No description provided.