Skip to content

docs: allow_extra_fields#42

Merged
jchavarri merged 2 commits into
mainfrom
docs-allow-extra-fields
Mar 17, 2025
Merged

docs: allow_extra_fields#42
jchavarri merged 2 commits into
mainfrom
docs-allow-extra-fields

Conversation

@jchavarri

Copy link
Copy Markdown
Member

Adds docs for json.allow_extra_fields.

@andreypopp

Copy link
Copy Markdown
Collaborator

The only catch is that json.allow_extra_fields is the default for browser ppx — we don't check for extra fields there. 😬

@jchavarri

Copy link
Copy Markdown
Member Author

Ah, interesting! Would it make sense to consolidate? If we do so, maybe we can make ignoring extra fields the default on both native and js, and add a decorator @json.strict. I think that allowing extra fields is a more common use case. Wdyt?

@andreypopp

Copy link
Copy Markdown
Collaborator

Sounds like a good idea.

@Khady

Khady commented Mar 17, 2025

Copy link
Copy Markdown
Collaborator

just stumbled onto some code using this annotation and the lack of doc. Would be worth merging something IMO.

@jchavarri

Copy link
Copy Markdown
Member Author

Created #63 to track the migration to strict.

@jchavarri
jchavarri merged commit 9aaafb6 into main Mar 17, 2025
@jchavarri
jchavarri deleted the docs-allow-extra-fields branch March 17, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants