This repository was archived by the owner on Apr 4, 2023. It is now read-only.
Throw an error on unknown fields specified in the _geo field #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
added
bug
irevoire
force-pushed
the
error-on-extra-field-in-geo
branch
from
36c2a47 to
de3c4f1
Compare
loiclec
approved these changes
Jan 24, 2023
Contributor
loiclec
left a comment
loiclec
left a comment
There was a problem hiding this comment.
Looks good, thank youuuu :)
| documents!({ "id" : "doggo", "_geo": { "lat": 1, "lng": 2, "doggo": "are the best" }}), | ||
| ) | ||
| .unwrap_err(); | ||
| insta::assert_display_snapshot!(err, @r###"The `_geo` field in the document with the id: `"\"doggo\""` contains the following unexpected fields: `{"doggo":"are the best"}`."###); |
Contributor
There was a problem hiding this comment.
`{"doggo":"are the best"}`This could be a bit confusing, because this object appears nowhere in the original document. I don't know what the alternative should be though, and it's just an error message, so not a big deal.
Contributor
Author
There was a problem hiding this comment.
Yeah I thought of displaying only a list of field name, but then I found it a bit confusing as well when it comes to more complex values 😩
I guess we’ll wait and see, if people complains about this message we’ll change it.
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix parts of meilisearch/meilisearch#3414