This repository was archived by the owner on Apr 4, 2023. It is now read-only.
Fix hard-deletion of an external id that was soft-deleted and then reimported - release-v0.37.5 #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiclec
force-pushed
the
fix-bug-3021-release-0.37.5
branch
from
84a9514 to
a7816ef
Compare
loiclec
changed the title
loiclec
added
bug
curquiza
reviewed
Dec 20, 2022
Member
curquiza
left a comment
curquiza
left a comment
There was a problem hiding this comment.
I approve the fact the PR is going to be merged into the right branch, but I don't approve the code of course 👌
thanks lo!
irevoire
approved these changes
Dec 20, 2022
Contributor
irevoire
left a comment
irevoire
left a comment
There was a problem hiding this comment.
Did you run your fuzzer again on this branch, just in case? 👀
Contributor
|
bors merge |
Contributor
|
Build succeeded:
|
Contributor
Author
|
Yes, the fuzz test was done on this branch initially :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that cherry-picks the commit from #750 onto
release-v0.37.5