This repository was archived by the owner on Apr 4, 2023. It is now read-only.
Fix the facet string docids filterable deletion bug #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Aug 20, 2021
318: Revert "Sort at query time" r=Kerollmops a=curquiza Reverts #309 We revert this from `main` not because this leads to a bug, but because we don't want to release it now and we have to merge and release an hotfix on `main`. Cf: - #316 - #317 Once the v0.21.0 is released, we should merge again this awesome addition 👌 Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
bors bot
added a commit
that referenced
this pull request
Aug 21, 2021
318: Revert "Sort at query time" r=Kerollmops a=curquiza Reverts #309 We revert this from `main` not because this leads to a bug, but because we don't want to release it now and we have to merge and release an hotfix on `main`. Cf: - #316 - #317 Once the v0.21.0 is released, we should merge again this awesome addition 👌 Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
curquiza
previously approved these changes
Aug 23, 2021
Member
curquiza
left a comment
curquiza
left a comment
There was a problem hiding this comment.
I tested with MeiliSearch, it works 🎉
ManyTheFish
suggested changes
Aug 23, 2021
Kerollmops
force-pushed
the
fix-deletion-filterable-attributes
branch
from
2bec369 to
ffaf924
Compare
Kerollmops
force-pushed
the
fix-deletion-filterable-attributes
branch
from
ffaf924 to
c084f7f
Compare
curquiza
approved these changes
Aug 23, 2021
curquiza
approved these changes
Aug 23, 2021
ManyTheFish
approved these changes
Aug 23, 2021
Member
Author
|
bors merge |
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the deletion of documents was returning a decoding error. But only when the settings are set with filterable attributes.
This bug was introduced in #254 in which we made the engine faster in returning the facet distribution. We changed the way we were storing the inverted index, we were no more storing only documents ids with the original values but also groups identified with integers, depending on the facet level we were using. This is similar to how facet numbers are already stored.
Related to meilisearch/meilisearch#1601.