Skip to content

Add Symfony 7.3 support #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025
Merged

Add Symfony 7.3 support #382

merged 1 commit into from
May 15, 2025

Conversation

norkunas
Copy link
Collaborator

Pull Request

Related issue

Fixes #381

What does this PR do?

  • Adds support for Symfony 7.3 and fixes deprecation warnings

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas added the enhancement New feature or request label May 13, 2025
@norkunas norkunas force-pushed the sf7.3 branch 6 times, most recently from 2ef693e to 78100fe Compare May 13, 2025 04:34
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (5e19616) to head (9f01002).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #382      +/-   ##
============================================
- Coverage     88.73%   88.41%   -0.32%     
  Complexity        1        1              
============================================
  Files            20       20              
  Lines           914      889      -25     
============================================
- Hits            811      786      -25     
  Misses          103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Symfony 7.3 and resolves deprecation warnings by updating baseline ignore messages, conditional container configuration, and command definitions. Key changes include:

  • Updated baseline ignore messages to address new deprecation warnings in symfony/var-exporter.
  • Added a version check in the Kernel configuration to disable the constructor extractor for Symfony 7.3+.
  • Converted command definitions to use attributes (#[AsCommand]) while removing legacy static getters and updating service configuration and workflow matrices.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/baseline-ignore Added deprecation messages for Symfony 7.3 related var-exporter changes.
tests/Kernel.php Introduced a version check to conditionally adjust the container configuration.
src/Command/*.php Updated command classes to leverage Symfony's attribute-based command definitions.
config/services.xml Updated service tags with explicit command names and descriptions.
.github/workflows/tests.yml Added Symfony 7.3 to the test matrix and configured minimum stability for it.
.github/workflows/pre-release-tests.yml Added Symfony 7.3 to the pre-release test matrix with appropriate exclusions.

@Strift Strift self-requested a review May 14, 2025 04:44
Copy link
Contributor

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with Symfony, but this LGTM.

I agree with the nitpicking feedback from Copilot; adding comments would make the code base a bit more self-documented.

@norkunas
Copy link
Collaborator Author

@Strift added comment

@norkunas
Copy link
Collaborator Author

bors merge

@norkunas norkunas merged commit 6197f10 into meilisearch:main May 15, 2025
22 of 23 checks passed
@norkunas norkunas deleted the sf7.3 branch May 15, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warnings in Symfony 7.3
2 participants