-
Notifications
You must be signed in to change notification settings - Fork 33
Add Symfony 7.3 support #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2ef693e
to
78100fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
============================================
- Coverage 88.73% 88.41% -0.32%
Complexity 1 1
============================================
Files 20 20
Lines 914 889 -25
============================================
- Hits 811 786 -25
Misses 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Symfony 7.3 and resolves deprecation warnings by updating baseline ignore messages, conditional container configuration, and command definitions. Key changes include:
- Updated baseline ignore messages to address new deprecation warnings in symfony/var-exporter.
- Added a version check in the Kernel configuration to disable the constructor extractor for Symfony 7.3+.
- Converted command definitions to use attributes (#[AsCommand]) while removing legacy static getters and updating service configuration and workflow matrices.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
tests/baseline-ignore | Added deprecation messages for Symfony 7.3 related var-exporter changes. |
tests/Kernel.php | Introduced a version check to conditionally adjust the container configuration. |
src/Command/*.php | Updated command classes to leverage Symfony's attribute-based command definitions. |
config/services.xml | Updated service tags with explicit command names and descriptions. |
.github/workflows/tests.yml | Added Symfony 7.3 to the test matrix and configured minimum stability for it. |
.github/workflows/pre-release-tests.yml | Added Symfony 7.3 to the pre-release test matrix with appropriate exclusions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with Symfony, but this LGTM.
I agree with the nitpicking feedback from Copilot; adding comments would make the code base a bit more self-documented.
@Strift added comment |
bors merge |
Pull Request
Related issue
Fixes #381
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements: