Skip to content

Fix tests for v1.14 #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025
Merged

Fix tests for v1.14 #380

merged 4 commits into from
Apr 8, 2025

Conversation

Strift
Copy link
Contributor

@Strift Strift commented Apr 4, 2025

Pull Request

Related issue

The tests against Meilisearch v1.14 are failing due to assertions on filterable attributes.

When the order of the filterable attributes changes in the API response, the tests fail. See failing tests

@dureuill confirmed that the attribute order was never guaranteed in the first place, so we should make this test more permissive by only checking the attribute presence, not their order.

What does this PR do?

  • Update the tests to only check the presence of the filterable attributes, not their order
  • Update pre-release-tests.yml to use the same exclusion combinations as tests.yml (it was leading to incompatible symfony + PHP versions)

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Strift Strift requested a review from Copilot April 4, 2025 05:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • tests/Integration/Command/MeilisearchCreateCommandTest.php: Language not supported
  • tests/Integration/Command/MeilisearchImportCommandTest.php: Language not supported
  • tests/Integration/SettingsTest.php: Language not supported
  • tests/Unit/SerializationTest.php: Language not supported
Comments suppressed due to low confidence (1)

.github/workflows/pre-release-tests.yml:63

  • Confirm that the introduced PHP 7.4 setup with Symfony 7.2, along with the additional PHP 8.0 and 8.1 configurations, is properly covered by tests and reflects intended compatibility requirements.
          - php-version: '7.4'

@Strift Strift requested a review from norkunas April 4, 2025 05:39
@Strift Strift requested a review from norkunas April 8, 2025 02:04
@Strift Strift merged commit 25a5fb3 into bump-meilisearch-v1.14.0 Apr 8, 2025
19 checks passed
@Strift Strift deleted the fix-tests-for-v1.14 branch April 8, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants