Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
The tests against Meilisearch v1.14 are failing due to assertions on filterable attributes.
When the order of the filterable attributes changes in the API response, the tests fail. See failing tests
@dureuill confirmed that the attribute order was never guaranteed in the first place, so we should make this test more permissive by only checking the attribute presence, not their order.
What does this PR do?
pre-release-tests.yml
to use the same exclusion combinations astests.yml
(it was leading to incompatible symfony + PHP versions)PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!