Skip to content

Always use prefixed_name #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Always use prefixed_name #356

merged 1 commit into from
Oct 4, 2024

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented Oct 4, 2024

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • Uses prefixed_name for operations as it's always available instead of transforming again

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (e98e4c8) to head (396ff0e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #356      +/-   ##
============================================
- Coverage     88.69%   88.62%   -0.07%     
  Complexity        1        1              
============================================
  Files            20       20              
  Lines           902      897       -5     
============================================
- Hits            800      795       -5     
  Misses          102      102              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkunas norkunas merged commit 0e2d7d8 into meilisearch:main Oct 4, 2024
13 checks passed
@norkunas norkunas deleted the prefixed branch October 4, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant