Skip to content

Add an option to use index swap in import command #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Add an option to use index swap in import command #354

merged 3 commits into from
Oct 2, 2024

Conversation

thislg
Copy link
Contributor

@thislg thislg commented Oct 1, 2024

Pull Request

Related issue

Fixes #277

What does this PR do?

  • This PR adds an option to use index swap to prevent downtime while importing data in an existing index.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@thislg thislg changed the title Implement index swap in import command Add an option to use index swap in import command Oct 1, 2024
@thislg thislg marked this pull request as draft October 1, 2024 15:24
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.72%. Comparing base (3ecb667) to head (83dc2f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #354      +/-   ##
============================================
+ Coverage     87.77%   88.72%   +0.95%     
  Complexity        1        1              
============================================
  Files            20       20              
  Lines           875      905      +30     
============================================
+ Hits            768      803      +35     
+ Misses          107      102       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thislg thislg marked this pull request as ready for review October 1, 2024 16:12
@thislg thislg requested a review from norkunas October 1, 2024 16:12
@thislg thislg requested a review from norkunas October 2, 2024 07:21
Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>
@thislg thislg requested a review from norkunas October 2, 2024 07:24
Copy link
Collaborator

@norkunas norkunas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@norkunas
Copy link
Collaborator

norkunas commented Oct 2, 2024

bors merge

@meili-bors meili-bors bot merged commit a6ee705 into meilisearch:main Oct 2, 2024
12 checks passed
@norkunas
Copy link
Collaborator

norkunas commented Oct 2, 2024

Thank you @thislg

@thislg thislg deleted the enable-index-swap branch October 2, 2024 07:29
@thislg
Copy link
Contributor Author

thislg commented Oct 2, 2024

Thank you for your time @norkunas

@curquiza curquiza added the enhancement New feature or request label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable re-indexation with indexSwap
3 participants