Skip to content

Allow to autowire Engine #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented Aug 20, 2024

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • Allows to autowire Engine service. Need this in my own app

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.75%. Comparing base (e110588) to head (2ffc217).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #346   +/-   ##
=========================================
  Coverage     87.75%   87.75%           
  Complexity        1        1           
=========================================
  Files            20       20           
  Lines           874      874           
=========================================
  Hits            767      767           
  Misses          107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkunas
Copy link
Collaborator Author

bors merge

@meili-bors meili-bors bot merged commit e151ae0 into meilisearch:main Aug 20, 2024
14 checks passed
@norkunas norkunas deleted the engine-autowiring branch August 20, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant