Skip to content

Fixed Engine::remove() when multiple entities are provided #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

remigarcia
Copy link
Contributor

Pull Request

Related issue

Fixes #341

What does this PR do?

  • fixing the Engine::remove() method which was only removing the first object when multiple objects were provided

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@norkunas
Copy link
Collaborator

norkunas commented Aug 1, 2024

Thank you, please add a test

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.75%. Comparing base (2b72ab6) to head (5e1f5cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #342      +/-   ##
============================================
+ Coverage     87.61%   87.75%   +0.14%     
  Complexity        1        1              
============================================
  Files            20       20              
  Lines           872      874       +2     
============================================
+ Hits            764      767       +3     
+ Misses          108      107       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remigarcia
Copy link
Contributor Author

Thank you, please add a test

Thanks for your fast feedback.
I just pushed the related test.

@norkunas
Copy link
Collaborator

norkunas commented Aug 1, 2024

bors merge

@meili-bors meili-bors bot merged commit ecac616 into meilisearch:main Aug 1, 2024
14 checks passed
@norkunas
Copy link
Collaborator

norkunas commented Aug 1, 2024

Thank you @remigarcia

@remigarcia
Copy link
Contributor Author

Thanks for the really fast feedback @norkunas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Engine::remove() issue when multiple entities are passed
2 participants