Drop support of symfony 4

[Chris53897]

Blocked by

• matthiasnoback/symfony-dependency-injection-testsing
• Allow using Symfony 7 dependencies php-http/client-common#232

please see
#265 (comment)
and #300

[curquiza]

Hello @Chris53897

Don't forget to update the bors file accordingly, if you add or remove jobs in the CI 😊

https://github.com/meilisearch/meilisearch-symfony/blob/main/bors.toml

[Chris53897]

Thanks for the reminder. I forgot it again :(
I have added it now.

[Chris53897]

Testruns for PHP 8.3 are blocked by shivammathur/setup-php#789

[norkunas]

This is missing Symfony 6.4

[Chris53897]

I have added tests for Symfony 6.4 now.
Now waiting for the blocking PR. (see on top of page)

[norkunas]

Instead of Empty-Commit just do git commit --amend --no-edit 🙂

[Chris53897]

Ok, will do. I saved it to my snippets.

[Chris53897]

@norkunas Any tip how to solve the problems with the run for symfony 5.4 and 6.0?

The problem, ist that we get a deprecation wanring, if we do not set the entry.
But on the other side the test-config is for symfony 5 and 6.
https://github.com/meilisearch/meilisearch-symfony/pull/301/files#diff-a875c960177021258e97cd9e7b3989ff28a6c851d04a2ebb15ccc41c14889a55R17

a) Make different config-files for 5.4, 6.0, 6.1 ? At best include a basic config-file and just change one line.
b) Add it dynamic in php conditionally fo config
c) Ignore the deprecation
d) ...

[norkunas]

I'd conditionally require var-exporter when it is needed, like when we conditionally remove doctrine/annotations

[norkunas]

As we all want to release Symfony 7 support faster, then we should currently avoid dropping 4.4 support as two blocker issues popped up that needs to be fixed before

[Chris53897]

@norkunas I added a new PR. But i am on holidays starting from friday (until 19.12). And not much time tomorrow.
Feel free to finish it.

[norkunas]

bors merge