Skip to content

Support Symfony 6 #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2021
Merged

Support Symfony 6 #146

merged 2 commits into from
Dec 20, 2021

Conversation

norkunas
Copy link
Collaborator

Pull Request

What does this PR do?

Fixes #143
Embeds #145 (should be merged first)

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas changed the title Sf6 support Support Symfony 6 Dec 20, 2021
@curquiza
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Dec 20, 2021
@bors
Try #146:
8211004
@bors
Copy link
Contributor

bors bot commented Dec 20, 2021

try

Build succeeded:

@curquiza
Copy link
Member

Hello @norkunas! Thanks for this batch of PRs!!

Could you please update the bors.toml file at the root of the repo with the new test: integration-tests (PHP 8.1)?

@norkunas
Copy link
Collaborator Author

Sure. just please merge the embed PR so I can rebase this one :)

@curquiza
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Dec 20, 2021
@bors
Try #146:
23e266e
@bors
Copy link
Contributor

bors bot commented Dec 20, 2021

try

Build succeeded:

curquiza
curquiza approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !!! bors merge

@curquiza
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 20, 2021

Build succeeded:

@bors bors bot merged commit e55b141 into meilisearch:main Dec 20, 2021
@norkunas norkunas deleted the sf6-support branch December 20, 2021 17:04
@curquiza curquiza added the enhancement New feature or request label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Symfony 6
2 participants
@norkunas @curquiza