Added getOrCreateIndex function #7
Conversation
There was a problem hiding this comment.
Thanks for your work and the tests!
I'm going to ask for Quentin to do a better review for the Swift part 🙂
PS: could you please put your PR as a draft (or at least a title with WIP in it) if you don't want us to merge 😊 We can do a review anyway if you ask for!
|
@qdequele Yes I am, are you asking about the number of tabs? If yes I can see where you are coming from, there is a file with 1 tab instead of one, I will fix it. The Swiftlint linter does not detect this I think. |
| completion(.failure(error)) | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
@ppamorim No, I tell that because I see sometimes an empty line behind a scope close bracket. Like on these lines.
There was a problem hiding this comment.
From where this rule is coming from? swiftlint does not complain about it. If you want you can open an issue that we can fix it since this is all over the project.
Please check this out: https://google.github.io/swift/#braces
There was a problem hiding this comment.
Thanks @ppamorim. It's not a problem. I'm sorry I slowed things down.
|
Thank you all! |
Implements the #4. Please do not merge yet due missing documentation.