Skip to content

Conversation

@curquiza
Copy link
Member

@curquiza curquiza commented Dec 1, 2025

Ruleset set up for the usage of GitHub merge queue ✅

Summary by CodeRabbit

  • Documentation

    • Simplified contributor documentation by removing PR automation and rebasing guidance.
    • Removed project branding reference from README.
  • Chores

    • Updated CI/CD workflow trigger configuration to use new event mechanisms instead of branch-specific triggers.
    • Removed bot mention pattern from release template configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Dec 1, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

Walkthrough

These changes systematically remove Bors, an automation bot for CI management, from the project. The removals include eliminating Bors references from release templates, removing Bors-triggered CI branches (trying and staging), deleting related automation documentation, and removing the Bors badge from the README.

Changes

Cohort / File(s) Summary
Bors Bot Integration Removal
.github/release-draft-template.yml, README.md
Removed Bors bot replacer rule and the Bors-enabled badge.
CI Workflow Trigger Updates
.github/workflows/tests.yml
Removed trying and staging branch triggers from push events; added new merge_group trigger; retained main branch.
Automation Documentation
CONTRIBUTING.md
Removed guidance on keeping PR branches up-to-date with main, deleted the entire "Automation to Rebase and Merge the PRs" subsection, and removed release-drafter documentation references.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Straightforward removals of Bors integration across configuration and documentation files
  • No complex logic changes; consists of consistent, repetitive pattern of deletion
  • Minor attention needed to verify all Bors references are removed and workflow triggers align with new merge strategy

Poem

🐰 The bors bot bows out with grace so fine,
No more the trying, staging dance in line,
We merge more freely, fresh and bright,
Our workflows streamlined, oh what a sight!
A simpler path to the main we take,
One less automation for us to make!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove bors and use GitHub merge queue' directly and clearly describes the main changes across all modified files: removing bors configuration and related documentation, and replacing it with GitHub's merge queue integration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-bors

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f3917c0 and df9996f.

📒 Files selected for processing (4)
  • .github/release-draft-template.yml (0 hunks)
  • .github/workflows/tests.yml (1 hunks)
  • CONTRIBUTING.md (0 hunks)
  • README.md (0 hunks)
💤 Files with no reviewable changes (3)
  • README.md
  • CONTRIBUTING.md
  • .github/release-draft-template.yml
🔇 Additional comments (2)
.github/workflows/tests.yml (2)

8-8: ✅ Correct GitHub merge queue trigger configuration.

Adding the merge_group trigger enables this workflow to run when PRs are added to GitHub's merge queue, replacing Bors's automation. The trigger correctly has no branch filters—GitHub's merge queue always targets the configured default branch.


14-14: The conditional logic is correct for merge_group events.

When merge_group events trigger the workflow, github.event_name will be 'merge_group' (not 'pull_request'), making the first condition true and the job will run as intended. Since github.base_ref is only available in pull_request context, the second condition is irrelevant for merge_group events due to the OR logic. The condition correctly allows integration tests to run on merge_group events, push to main, and push to bump branches, while skipping only PRs to bump-meilisearch-v* branches (which is the documented intent in the comment above the condition).


Comment @coderabbitai help to get the list of available commands and usage tips.

@curquiza curquiza requested a review from brunoocasali December 1, 2025 16:55
@curquiza curquiza merged commit 85111e6 into main Dec 2, 2025
5 of 6 checks passed
@curquiza curquiza deleted the remove-bors branch December 2, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Anything related to maintenance (CI, tests, refactoring...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants