Skip to content

Fix: remove charset=utf-8 from Content-Type header #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2021
Merged

Fix: remove charset=utf-8 from Content-Type header #205

merged 1 commit into from
Oct 5, 2021

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Oct 4, 2021

No description provided.

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Oct 4, 2021
@curquiza curquiza requested a review from bidoubiwa October 4, 2021 18:23
bidoubiwa
bidoubiwa reviewed Oct 5, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you didn't setValue for the get method. Is there a reason?

@curquiza
Copy link
Member Author

curquiza commented Oct 5, 2021

I see you didn't setValue for the get method. Is there a reason?

Which part do you mean? There is no setValue regarding the content type for the get method, right?

@bidoubiwa
Copy link
Contributor

Ah yes, my bad!

bidoubiwa
bidoubiwa approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 5, 2021

Build succeeded:

@bors bors bot merged commit 86d323b into bump-meilisearch-v0.23.0 Oct 5, 2021
@bors bors bot deleted the fix-tests branch October 5, 2021 10:03
@bidoubiwa bidoubiwa added breaking-change The related changes are breaking for the users and removed skip-changelog The PR will not appear in the release changelogs labels Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curquiza @bidoubiwa