-
Notifications
You must be signed in to change notification settings - Fork 102
Add facet_search API functionality #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add facet_search API functionality
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 9
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.code-samples.meilisearch.yaml(1 hunks)src/indexes.rs(1 hunks)src/search.rs(2 hunks)
🧰 Additional context used
🧠 Learnings (3)
.code-samples.meilisearch.yaml (1)
Learnt from: LukasKalbertodt
PR: meilisearch/meilisearch-rust#625
File: src/search.rs:368-370
Timestamp: 2025-06-12T13:28:23.700Z
Learning: In the Meilisearch Rust client, `SearchQuery` serializes its per-query federation settings under the key `federationOptions`; only the top-level multi-search parameter is named `federation`.
src/indexes.rs (1)
Learnt from: LukasKalbertodt
PR: meilisearch/meilisearch-rust#625
File: src/search.rs:368-370
Timestamp: 2025-06-12T13:28:23.700Z
Learning: In the Meilisearch Rust client, `SearchQuery` serializes its per-query federation settings under the key `federationOptions`; only the top-level multi-search parameter is named `federation`.
src/search.rs (1)
Learnt from: LukasKalbertodt
PR: meilisearch/meilisearch-rust#625
File: src/search.rs:368-370
Timestamp: 2025-06-12T13:28:23.700Z
Learning: In the Meilisearch Rust client, `SearchQuery` serializes its per-query federation settings under the key `federationOptions`; only the top-level multi-search parameter is named `federation`.
🪛 GitHub Actions: Tests
src/indexes.rs
[error] 319-319: Cannot find function request in this scope. The function request is called but not defined or imported.
[error] 329-329: Mismatched types error: expected reference &Index<ReqwestClient>, found &Index<Http>. The argument to FacetSearchQuery::new is incorrect due to type parameter mismatch.
🔇 Additional comments (3)
src/indexes.rs (1)
282-314: Excellent documentation with comprehensive example.The documentation provides a complete usage example including the necessary setup steps (setting filterable attributes) and demonstrates the expected workflow. This follows the established patterns in the codebase well.
src/search.rs (2)
797-810: LGTM!The response types are well-structured with appropriate serde annotations and match the expected API response format.
1458-1570: Excellent test coverage!The tests comprehensively cover all facet search functionality including basic search, queries, filters, and matching strategies. They follow the established testing patterns and include proper assertions.
Pull Request
Rework of PR #512
Related issue
Fixes #503
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit
New Features
Tests