fix(indexes): allow None primary_key in add_or_update function
#557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @curquiza , sorry for the late response. I added the test case. |
irevoire
reviewed
Apr 8, 2024
curquiza
added
the
breaking-change
Member
|
bors try |
Contributor
tryBuild failed: |
meili-bors bot
added a commit
that referenced
this pull request
Apr 15, 2024
557: fix(indexes): allow None `primary_key` in `add_or_update` function r=irevoire a=khanhnt2 # Pull Request ## Related issue Cannot pass `None` value to `add_or_update` function ## What does this PR do? Replace `impl AsRef<str>` to `&str` ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Nguyen Trung Khanh <nguyentrungkhanh97@gmail.com> Co-authored-by: Khanh Nguyen <nguyentrungkhanh97@gmail.com> Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com> Co-authored-by: Tamo <tamo@meilisearch.com>
Contributor
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
meili-bors bot
added a commit
that referenced
this pull request
Apr 15, 2024
557: fix(indexes): allow None `primary_key` in `add_or_update` function r=irevoire a=khanhnt2 # Pull Request ## Related issue Cannot pass `None` value to `add_or_update` function ## What does this PR do? Replace `impl AsRef<str>` to `&str` ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Nguyen Trung Khanh <nguyentrungkhanh97@gmail.com> Co-authored-by: Khanh Nguyen <nguyentrungkhanh97@gmail.com> Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com> Co-authored-by: Tamo <tamo@meilisearch.com>
Contributor
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Cannot pass
Nonevalue toadd_or_updatefunctionWhat does this PR do?
Replace
impl AsRef<str>to&strPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!