Skip to content

Conversation

@curquiza
Copy link
Member

@curquiza curquiza commented May 24, 2021

Should be merged after #136

steps:
- uses: actions/checkout@v2
- name: Build
run: cargo build --example web_app
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think cargo build —example web_app will catch the error that happened in #135. When I ran this against the current code this build completed without error. The error didn’t show up until building with cargo build --lib --release --target wasm32-unknown-unknown

Copy link
Collaborator

@Mubelotix Mubelotix May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. The command that should be used is cargo check --example web_app --target wasm32-unknown-unknown

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: cargo build --example web_app
run: cargo check --example web_app --target wasm32-unknown-unknown

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, thanks to both of you

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an error with this command but not the expected one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@sanders41 sanders41 May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an error with this command but not the expected one

I'm not sure if this will work in GitHub actions, but try

steps:
- uses: actions/checkout@v2
- name: Build
  run:
    rustup target add wasm32-unknown-unknown
    cargo check --example web_app --target wasm32-unknown-unknown

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thaaaaaanks!!! Hard day for me 😂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It faiiiils! So it works!!! 🎉

@curquiza curquiza linked an issue May 24, 2021 that may be closed by this pull request
@curquiza curquiza marked this pull request as draft May 24, 2021 11:13
@curquiza curquiza marked this pull request as ready for review May 24, 2021 17:03
@curquiza curquiza requested a review from Mubelotix May 24, 2021 17:08
@curquiza
Copy link
Member Author

I put you @Mubelotix as the final reviewer 😇

@curquiza
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request May 26, 2021
@bors
Copy link
Contributor

bors bot commented May 26, 2021

try

Build succeeded:

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label May 26, 2021
@curquiza
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 12, 2021

Build succeeded:

@bors bors bot merged commit 0603945 into main Jun 12, 2021
@bors bors bot deleted the add-wasm-ci branch June 12, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WASM Build In CI

4 participants