-
Notifications
You must be signed in to change notification settings - Fork 102
Add job in CI for wasm build #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/tests.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Build | ||
| run: cargo build --example web_app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think cargo build —example web_app will catch the error that happened in #135. When I ran this against the current code this build completed without error. The error didn’t show up until building with cargo build --lib --release --target wasm32-unknown-unknown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. The command that should be used is cargo check --example web_app --target wasm32-unknown-unknown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| run: cargo build --example web_app | |
| run: cargo check --example web_app --target wasm32-unknown-unknown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, thanks to both of you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have an error with this command but not the expected one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have an error with this command but not the expected one
I'm not sure if this will work in GitHub actions, but try
steps:
- uses: actions/checkout@v2
- name: Build
run:
rustup target add wasm32-unknown-unknown
cargo check --example web_app --target wasm32-unknown-unknownThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thaaaaaanks!!! Hard day for me 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It faiiiils! So it works!!! 🎉
|
I put you @Mubelotix as the final reviewer 😇 |
|
bors try |
tryBuild succeeded: |
|
bors merge |
|
Build succeeded: |
Should be merged after #136