Skip to content

Update settings tests to assert field inclusion in API responses #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 24 additions & 22 deletions spec/meilisearch/index/settings_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -545,30 +545,30 @@
before { client.create_index(uid).await }

it '#pagination gets default values of pagination' do
expect(index.pagination).to eq(default_pagination.transform_keys(&:to_s))
expect(index.pagination).to include(default_pagination.transform_keys(&:to_s))
end

describe '#update_pagination' do
it 'updates pagination' do
index.update_pagination(pagination).await
expect(index.pagination).to eq(pagination_with_string_keys)
expect(index.pagination).to include(pagination_with_string_keys)
end

it 'resets pagination when passed nil' do
index.update_pagination(pagination).await
expect(index.pagination).to eq(pagination_with_string_keys)
expect(index.pagination).to include(pagination_with_string_keys)

index.update_pagination(nil).await
expect(index.pagination).to eq(default_pagination.transform_keys(&:to_s))
expect(index.pagination).to include(default_pagination.transform_keys(&:to_s))
end
end

it '#reset_pagination resets pagination' do
index.update_pagination(pagination).await
expect(index.pagination).to eq(pagination_with_string_keys)
expect(index.pagination).to include(pagination_with_string_keys)

index.reset_pagination.await
expect(index.pagination).to eq(default_pagination.transform_keys(&:to_s))
expect(index.pagination).to include(default_pagination.transform_keys(&:to_s))
end
end

Expand Down Expand Up @@ -603,21 +603,21 @@
before { client.create_index(uid).await }

it '#typo_tolerance gets default typo tolerance settings' do
expect(index.typo_tolerance).to eq(default_typo_tolerance)
expect(index.typo_tolerance).to include(default_typo_tolerance)
end

it '#update_type_tolerance updates typo tolerance settings' do
index.update_typo_tolerance(new_typo_tolerance).await

expect(index.typo_tolerance).to eq(Meilisearch::Utils.transform_attributes(new_typo_tolerance))
expect(index.typo_tolerance).to include(Meilisearch::Utils.transform_attributes(new_typo_tolerance))
end

it '#reset_typo_tolerance resets typo tolerance settings' do
index.update_typo_tolerance(new_typo_tolerance).await
expect(index.typo_tolerance).to eq(Meilisearch::Utils.transform_attributes(new_typo_tolerance))
expect(index.typo_tolerance).to include(Meilisearch::Utils.transform_attributes(new_typo_tolerance))

index.reset_typo_tolerance.await
expect(index.typo_tolerance).to eq(default_typo_tolerance)
expect(index.typo_tolerance).to include(default_typo_tolerance)
end
end

Expand All @@ -629,34 +629,34 @@
before { client.create_index(uid).await }

it '#faceting gets default values of faceting' do
expect(index.faceting).to eq(default_faceting_with_string_keys)
expect(index.faceting).to include(default_faceting_with_string_keys)
end

describe '#update_faceting' do
it 'updates faceting' do
index.update_faceting({ 'max_values_per_facet' => 333 }).await
new_faceting = default_faceting_with_string_keys.merge('maxValuesPerFacet' => 333)

expect(index.faceting).to eq(new_faceting)
expect(index.faceting).to include(new_faceting)
end

it 'resets faceting when passed nil' do
index.update_faceting({ 'max_values_per_facet' => 333 }).await
new_faceting = default_faceting_with_string_keys.merge('maxValuesPerFacet' => 333)
expect(index.faceting).to eq(new_faceting)
expect(index.faceting).to include(new_faceting)

index.update_faceting(nil).await
expect(index.faceting).to eq(default_faceting_with_string_keys)
expect(index.faceting).to include(default_faceting_with_string_keys)
end
end

it '#reset_faceting resets faceting' do
index.update_faceting({ 'max_values_per_facet' => 333 }).await
new_faceting = default_faceting_with_string_keys.merge('maxValuesPerFacet' => 333)
expect(index.faceting).to eq(new_faceting)
expect(index.faceting).to include(new_faceting)

index.reset_faceting.await
expect(index.faceting).to eq(default_faceting_with_string_keys)
expect(index.faceting).to include(default_faceting_with_string_keys)
end
end

Expand Down Expand Up @@ -781,19 +781,21 @@
[{ attribute_patterns: ['title'], locales: ['eng'] }]
).await

expect(index.localized_attributes).to eq(
[{ 'attributePatterns' => ['title'], 'locales' => ['eng'] }]
)
result = index.localized_attributes
expect(result).to be_an(Array)
expect(result.length).to eq(1)
expect(result.first).to include('attributePatterns' => ['title'], 'locales' => ['eng'])
end

it '#reset_localized_attributes resets localized attributes' do
index.update_localized_attributes(
[{ attribute_patterns: ['title'], locales: ['eng'] }]
).await

expect(index.localized_attributes).to eq(
[{ 'attributePatterns' => ['title'], 'locales' => ['eng'] }]
)
result = index.localized_attributes
expect(result).to be_an(Array)
expect(result.length).to eq(1)
expect(result.first).to include('attributePatterns' => ['title'], 'locales' => ['eng'])

index.reset_localized_attributes.await
expect(index.localized_attributes).to eq(default_localized_attributes)
Expand Down