Add federated search #393
Add federated search #393
Conversation
ellnix
force-pushed
the
federated-search
branch
2 times, most recently
from
0a09b55 to
78d662d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 89.62% 90.43% +0.80%
==========================================
Files 13 14 +1
Lines 781 847 +66
==========================================
+ Hits 700 766 +66
Misses 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ellnix
force-pushed
the
federated-search
branch
from
78d662d to
1e3c302
Compare
|
My team has been using the forked repo's branch in our staging environment and everything is working smoothly. We will push to prod soon, but would love to see this hit the mainline release pipeline before pulling the trigger in an ideal world. |
|
I will review this after the rebase or the merge of the class name change :) |
ellnix
force-pushed
the
federated-search
branch
from
1e3c302 to
d4080ed
Compare
| @@ -11,23 +12,59 @@ def multi_search(searches) | |||
| normalize(options, index_target) | |||
| end | |||
|
|
|||
| MultiSearchResult.new(searches, client.multi_search(search_parameters)) | |||
| MultiSearchResult.new(searches, client.multi_search(queries: search_parameters)) | |||
There was a problem hiding this comment.
This change is necessary due to this change in ms-ruby: meilisearch/meilisearch-ruby@055f7d0
ellnix
force-pushed
the
federated-search
branch
2 times, most recently
from
5a0b981 to
d2ab989
Compare
|
@brunoocasali Rebased and also removed |
|
|
||
| return if pagination_options.empty? | ||
|
|
||
| Meilisearch::Rails.logger.warn <<~WRONG_PAGINATION |
There was a problem hiding this comment.
These warnings will be very helpful!
| [condition_key, results_by_id] | ||
| end | ||
|
|
||
| def pk_is_virtual?(model_class, pk_method) |
There was a problem hiding this comment.
I guess this code comes from the meilisearch-rails main class, we can think in ways to make them reused across the whole gem.
There was a problem hiding this comment.
Yeah, I plan to remove them entirely 😆 if we go with the plan of enforcing the ms primary key to be same as the primary key of the model.
ellnix
force-pushed
the
federated-search
branch
from
d2ab989 to
da5d6f5
Compare
No soft deprecation here, since federated search has not been published yet.
ellnix
force-pushed
the
federated-search
branch
from
da5d6f5 to
8cb1a8d
Compare
|
bors merge |
|
Build succeeded: |
Pull Request
Related issue
Continues on top of #384
Fixes #389
I've got the general idea of the implementation, what's left is:
Ready for review