Skip to content

Remove extra line from readme example #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Remove extra line from readme example #977

merged 1 commit into from
Jun 11, 2024

Conversation

sanders41
Copy link
Collaborator

Pull Request

I just noticed that when I was updating the readme with a seriaizer example I accidentally include a line from a test that doesn't make sense in the context of the example. This removes that line.

Related issue

Fixes #<issue_number>

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the skip-changelog The PR will not appear in the release changelogs label Jun 10, 2024
@sanders41 sanders41 requested a review from curquiza June 10, 2024 23:09
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

bors merge

meili-bors bot added a commit that referenced this pull request Jun 11, 2024
977: Remove extra line from readme example r=curquiza a=sanders41

# Pull Request

I just noticed that when I was updating the readme with a seriaizer example I accidentally include a line from a test that doesn't make sense in the context of the example. This removes that line.

## Related issue
Fixes #<issue_number>

## What does this PR do?
- ...

## PR checklist
Please check if your PR fulfills the following requirements:
- [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [ ] Have you read the contributing guidelines?
- [ ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Paul Sanders <paul@paulsanders.dev>
Copy link
Contributor

meili-bors bot commented Jun 11, 2024

Build failed:

@curquiza
Copy link
Member

bors merge

Copy link
Contributor

meili-bors bot commented Jun 11, 2024

@sanders41 sanders41 merged commit a38cbac into main Jun 11, 2024
11 checks passed
@sanders41 sanders41 deleted the typo branch June 11, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants