-
Notifications
You must be signed in to change notification settings - Fork 94
Implement vector search experimental feature v2 (v1.6) #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e544a88
Add embedders classes
CaroFG fccdda6
Add embedders path
CaroFG 200b672
Add embedders subroutes
CaroFG 0836ca3
Update get_embedders method
CaroFG 0c9a408
Update embedders class
CaroFG ba98ef9
Add embedders settings tests
CaroFG ede85a0
Update vector search tests
CaroFG 68c4004
Format code with Black and sort imports with iSort
CaroFG 318eff1
Add new_embedders fixture
CaroFG b08caee
Use new_embedders fixture
CaroFG 7b7643b
Remove warning from README
CaroFG 2097c73
Fix formatting issue
CaroFG a25244e
Move fixture to conftest file to fix linting issue
CaroFG cfb57f1
Remove unnecessary usefixtures
CaroFG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
import pytest | ||
|
||
from meilisearch.models.index import Embedders | ||
|
||
NEW_EMBEDDERS = { | ||
"default": { | ||
"source": "userProvided", | ||
"dimensions": 1, | ||
} | ||
} | ||
|
||
|
||
@pytest.mark.usefixtures("enable_vector_search") | ||
def test_get_default_embedders(empty_index): | ||
"""Tests getting default embedders.""" | ||
response = empty_index().get_embedders() | ||
|
||
assert response is None | ||
|
||
|
||
@pytest.mark.usefixtures("enable_vector_search") | ||
def test_update_embedders_with_user_provided_source(empty_index): | ||
"""Tests updating embedders.""" | ||
index = empty_index() | ||
response_update = index.update_embedders(NEW_EMBEDDERS) | ||
update = index.wait_for_task(response_update.task_uid) | ||
response_get = index.get_embedders() | ||
print(response_get) | ||
assert update.status == "succeeded" | ||
assert response_get == Embedders(embedders=NEW_EMBEDDERS) | ||
CaroFG marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
@pytest.mark.usefixtures("enable_vector_search") | ||
def test_reset_embedders(empty_index): | ||
"""Tests resetting the typo_tolerance setting to its default value.""" | ||
index = empty_index() | ||
|
||
# Update the settings | ||
response_update = index.update_embedders(NEW_EMBEDDERS) | ||
update1 = index.wait_for_task(response_update.task_uid) | ||
# Get the setting after update | ||
response_get = index.get_embedders() | ||
# Reset the setting | ||
response_reset = index.reset_embedders() | ||
update2 = index.wait_for_task(response_reset.task_uid) | ||
# Get the setting after reset | ||
response_last = index.get_embedders() | ||
|
||
assert update1.status == "succeeded" | ||
assert response_get == Embedders(embedders=NEW_EMBEDDERS) | ||
assert update2.status == "succeeded" | ||
assert response_last is None | ||
CaroFG marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.