Implement POST route in search method #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskombro
force-pushed
the
implement_post_route_in_search_method
branch
2 times, most recently
from
fc787ea to
f3de7db
Compare
curquiza
reviewed
Jul 20, 2020
| 'attributesToHighlight': '*', | ||
| 'attributesToRetrieve': '*', | ||
| 'attributesToCrop': '*', | ||
| 'attributesToHighlight': ['*'], |
There was a problem hiding this comment.
Hum! These kinds of changes are breakable, right?
curquiza
reviewed
Jul 20, 2020
bidoubiwa
reviewed
Jul 20, 2020
| @@ -60,9 +60,9 @@ def test_custom_search_params_with_wildcard(self): | |||
| 'a', | |||
| { | |||
| 'limit': 5, | |||
| 'attributesToHighlight': '*', | |||
| 'attributesToRetrieve': '*', | |||
There was a problem hiding this comment.
The simple string "*" is not a valid entry ?
There was a problem hiding this comment.
It isn't for the post route. Do you think that's a core problem? A simple srting will creat a bad_request response
meilisearch/index.py
Outdated
| if key in ('facetsDistribution', 'facetFilters'): | ||
| opt_params[key] = json.dumps(opt_params[key]) | ||
| elif isinstance(opt_params[key], list): | ||
| opt_params[key] = ','.join(opt_params[key]) | ||
| params = { |
There was a problem hiding this comment.
Suggested change
| params = { | |
| body = { |
Suggested change
| params = { | |
| data = { |
Just better naming because those are not params anymore. But It's up to you if you want to change it.
eskombro
force-pushed
the
implement_post_route_in_search_method
branch
from
f3de7db to
9cd8b4b
Compare
curquiza
added
the
breaking-change
curquiza
approved these changes
Jul 20, 2020
bidoubiwa
approved these changes
Jul 20, 2020
|
Maybe wait for the meilisearch/meilisearch#866 final decision? |
eskombro
commented
Jul 20, 2020
Exactly, I opened that Issue and not planning to merge untill we get more info :) Thanks @curquiza ! |
|
Okay, I convert it to draft since we must not merge it 🙂 |
curquiza
pushed a commit
that referenced
this pull request
Aug 3, 2020
Implement POST route in search method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
POSTroute instead ofGETfor search methodNote:
attributesToHighlight,attributesToRetrieveandattributesToCropmust always be a list (array) instead of a string so it is properly deserialized by the serverCloses #126