-
Notifications
You must be signed in to change notification settings - Fork 103
Fixed pipenv compatibility issue #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed pipenv compatibility issue #1194
Conversation
📝 WalkthroughWalkthroughReplaced pipx-based pipenv installation with direct pip installation across four GitHub Actions workflows (documentation, pre-release tests, PyPI publishing, and tests). This standardizes the pipenv setup method and addresses the failing documentation build workflow. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/tests.yml (1)
47-48: Inconsistent:pylintjob still usespipx install pipenv.This job was not updated and still uses
pipx install pipenv, which contradicts the PR's objective to fix pipenv compatibility issues across all workflows.Proposed fix
- name: Install pipenv - run: pipx install pipenv + run: pip install pipenv
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/documentation.yml.github/workflows/pre-release-tests.yml.github/workflows/pypi-publish.yml.github/workflows/tests.yml
🔇 Additional comments (7)
.github/workflows/tests.yml (4)
29-29: LGTM!The pipenv installation method is correctly updated to use
pip install pipenv.
65-65: LGTM!Consistent with the other updated jobs.
82-82: LGTM!Consistent with the other updated jobs.
99-99: LGTM!Consistent with the other updated jobs.
.github/workflows/pypi-publish.yml (1)
20-21: LGTM!The pipenv installation method is correctly updated to use
pip install pipenv, consistent with the PR's objective..github/workflows/documentation.yml (1)
39-41: LGTM!This change directly addresses the failing documentation build referenced in issue
#1193. The pipenv installation method is correctly updated..github/workflows/pre-release-tests.yml (1)
26-27: LGTM!The pipenv installation method is correctly updated to use
pip install pipenv, consistent with the other workflow files.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Strift
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @jawad-khan, thanks for the fix :)
Pull Request
Related issue
Fixes #1193
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.