-
Notifications
You must be signed in to change notification settings - Fork 90
Give helpful error message when missing protocol #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how often that type of mistake happens, but it is always good to have a clear error message 🫡
Thanks a lot as usual @ellnix <3
Caution Review failedThe pull request is closed. WalkthroughThe changes introduce explicit handling for invalid URL schema errors in the HTTP request logic, providing a clearer error message when a URL is missing a scheme. A new test is added to verify that the improved error message is raised when initializing the client with a URL lacking a protocol. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Client
participant HttpRequests
participant RequestsLib
User->>Client: create_index()
Client->>HttpRequests: send_request()
HttpRequests->>RequestsLib: post()
RequestsLib-->>HttpRequests: raise InvalidSchema
HttpRequests-->>Client: raise MeilisearchCommunicationError (explicit message about missing scheme)
Client-->>User: Exception propagated
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fixes #1028
Summary by CodeRabbit
Bug Fixes
Tests