Skip to content

Adds documentation and an integration test case for the distinct keyword in index search #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

aweidner
Copy link
Contributor

Pull Request

Related issue

Fixes #989

What does this PR do?

This pull requests adds documentation for the distinct keyword in the code samples file. It also adds an integration test case that exercises the distinct functionality of search.

Note that the issue mentions adding the code sample for distinct_attribute but it looks like this code sample is already in place according to the docs: https://www.meilisearch.com/docs/learn/relevancy/distinct_attribute#setting-a-distinct-attribute-during-configuration. Happy to amend this PR if that's not the case and I'm misreading this.

PR checklist

Please check if your PR fulfills the following requirements:

  • [x ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [ x] Have you read the contributing guidelines?
  • [ x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Co-authored-by: Paul Sanders <psanders1@gmail.com>
@sanders41 sanders41 added the enhancement New feature or request label Aug 20, 2024
Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @aweidner!

bors merge

Copy link
Contributor

meili-bors bot commented Aug 20, 2024

@meili-bors meili-bors bot merged commit 7116204 into meilisearch:main Aug 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.9] Accept distinct search parameter
2 participants