[v1.4] Add word dictionary settings #571
Conversation
alallema
changed the title
| /** | ||
| * @param list<non-empty-string> $wordDictionary | ||
| */ | ||
| public function updateWordDictionary(array $wordDictionary): array |
There was a problem hiding this comment.
Can we typehint returned array structure?
There was a problem hiding this comment.
Yes, I thought about it, but all setting updates return a task, and none are specified, so I didn't put anything in.
There was a problem hiding this comment.
Then you could declare the Task return type in some file and then import the type where a task is returned,but then maybe in a separate PR :)
There was a problem hiding this comment.
I will create an issue about it. In the meantime I've just put array without details inside
There was a problem hiding this comment.
An alternative could be to introduce some value object that would hold the task info
|
I'd suggest to update CI to run with the docker image that supports these settings to see if tests works :) |
alallema
changed the title
The pre-release arrives on Monday and I'll just change the base branch for a bump so that the tests can run on it. |
Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com> Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>
alallema
force-pushed
the
prototype/word-dictionnary
branch
from
bc3d5c6 to
f6ff832
Compare
Pull Request
Related issue
Fixes #569
What does this PR do?