Update ESLint and related packages #1697
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flevi29
commented
Aug 21, 2024
eslint.config.js
Outdated
| /** @type {import('eslint').Linter.Config[]} */ | ||
| module.exports = [ | ||
| { | ||
| ignores: ['dist/', 'tests/env/', 'coverage/', 'playgrounds/', 'docs/'], |
There was a problem hiding this comment.
This is the replacement for .eslintignore https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files
flevi29
commented
Aug 21, 2024
| rules: eslint.configs.recommended.rules, | ||
| }, | ||
| // TypeScript linting for ts files | ||
| ...tseslint.configs.recommendedTypeChecked.map((config) => ({ |
There was a problem hiding this comment.
Now TypeScript rules are also applied to test files, which wasn't the case before.
flevi29
commented
Aug 21, 2024
| @@ -53,8 +53,8 @@ | |||
| "style:fix": "yarn fmt:fix && yarn lint:fix", | |||
| "fmt": "prettier -c ./**/*.{js,ts}", | |||
| "fmt:fix": "prettier -w ./**/*.{js,ts}", | |||
| "lint": "eslint --ext .js,.ts,.tsx .", | |||
There was a problem hiding this comment.
--ext is deprecated and removed, we just include the proper files now with globs pattern.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 21 21
Lines 831 831
Branches 84 84
=======================================
Hits 807 807
Misses 23 23
Partials 1 1 ☔ View full report in Codecov by Sentry. |
flevi29
force-pushed
the
update-eslint
branch
3 times, most recently
from
968b476
to
2f32001
Compare
flevi29
force-pushed
the
update-eslint
branch
from
2f32001
to
4753acd
Compare
This was referenced Sep 25, 2024
flevi29
force-pushed
the
update-eslint
branch
from
4753acd
to
974dbb0
Compare
flevi29
added
the
skip-changelog
nicolasvienot
changed the title
curquiza
removed
the
skip-changelog
|
@flevi29 don't put Also, can you fix the git conflicts? |
|
@curquiza fixed. |
meili-bors bot
added a commit
that referenced
this pull request
Oct 2, 2024
1697: Update ESLint and related packages r=curquiza a=flevi29 # Pull Request ## Why? ESLint received major upgrade from 8 -> 9. With this comes a new flat config. Also rules have been changed a little bit. This PR updates ESLint, related packages, and adapts config. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: F. Levi <55688616+flevi29@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Why?
ESLint received major upgrade from 8 -> 9. With this comes a new flat config. Also rules have been changed a little bit.
This PR updates ESLint, related packages, and adapts config.
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!