-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove .editorconfig
#1696
Remove .editorconfig
#1696
Conversation
I am not applying the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1696 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 21 21
Lines 831 831
Branches 84 84
=======================================
Hits 807 807
- Misses 23 24 +1
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve, but indeed the tests should be fixed before merging 😇
Should I do it? It will be a lot of changes, or so I presume. |
cb372fe
to
d904754
Compare
d904754
to
125468b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
Pull Request
Why?
.editorconfig
was added on the very first commit of this repository, but since thenprettier
has replaced it. Except it wasn't removed. There's no point in having multiple configurations for formatting. Related #1659, in which I wanted to remove all custom options, but didn't know why things still didn't work as they should, and now I know thatprettier
also takes.editorconfig
into consideration.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!