Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add attribute at search #1676

Merged
merged 1 commit into from
Jun 20, 2024
Merged

feat: add attribute at search #1676

merged 1 commit into from
Jun 20, 2024

Conversation

mdubus
Copy link
Member

@mdubus mdubus commented Jun 19, 2024

Pull Request

Related issue

Fixes #1674

What does this PR do?

  • Addition of a new distinct attribute on search (both on POST and GET)
  • Addition of the related tests

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@mdubus mdubus added the enhancement New feature or request label Jun 19, 2024
@mdubus mdubus requested a review from curquiza June 19, 2024 14:31
curquiza
curquiza approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiice

@curquiza curquiza merged commit 1716ac8 into bump-meilisearch-v1.9.0 Jun 20, 2024
6 checks passed
@curquiza curquiza deleted the add_new_distinct_attribute_at_search branch June 20, 2024 12:00
@curquiza curquiza mentioned this pull request Jun 20, 2024
Closed
2 tasks
@WontonSam WontonSam mentioned this pull request Jul 26, 2024
Open
@ramzimalhas ramzimalhas mentioned this pull request Aug 22, 2024
Open
@ferdi05 ferdi05 mentioned this pull request Sep 1, 2024
Open
This was referenced Sep 7, 2024
Open
Open
This was referenced Sep 21, 2024
Open
Open
@KaliforniaShell KaliforniaShell mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdubus @curquiza