Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frequency matching strategy #1670

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

the-sinner
Copy link
Contributor

Pull Request

Related issue

Fixes #1666

What does this PR do?

  • Add frequency matching strategy

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza curquiza added the enhancement New feature or request label Jun 10, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much again!

Can you fix the style check?
This time I was able to reproduce it on my machine

Comment on lines 366 to 369
search_parameter_guide_matching_strategy_3: |-
client.index('movies').search('big fat liar', {
matchingStrategy: 'frequency'
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
search_parameter_guide_matching_strategy_3: |-
client.index('movies').search('big fat liar', {
matchingStrategy: 'frequency'
})

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I remove this because I don't know yet what documentation will ask from us, I will update it myself, don't worry
Thanks for helping

tests/search.test.ts Outdated Show resolved Hide resolved
@curquiza curquiza merged commit 1d6507e into meilisearch:bump-meilisearch-v1.9.0 Jun 11, 2024
6 checks passed
@curquiza curquiza linked an issue Jun 11, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.9.0] New matching strategy variant: frequency
2 participants