-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rankingScoreThreshold in search #1669
Add rankingScoreThreshold in search #1669
Conversation
I have added the error code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@the-sinner
I see we have issue with the style-check
CI. Can you fix it?
Thank you so much for being everywhere ❤️
src/types/types.ts
Outdated
@@ -1010,6 +1011,8 @@ export const ErrorStatusCode = { | |||
|
|||
/** @see https://www.meilisearch.com/docs/reference/errors/error_codes#invalid_facet_search_facet_query */ | |||
INVALID_FACET_SEARCH_FACET_QUERY: 'invalid_facet_search_facet_query', | |||
|
|||
INVALID_SEARCH_RANKING_SCORE_THRESHOLD:'invalid_search_ranking_score_threshold', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the error code invalid_search_ranking_score_threshold in types.ts. Is it fine ?
It's fine!
Shouldn't we also add invalid_similar_ranking_score_threshold
based on the usage page (last section): https://meilisearch.notion.site/Filter-by-score-usage-224a183ce7b24ca99b6a9a8da755668a
9990377
to
5172d2a
Compare
i have added the other error code as well. |
Checking on my side now... Same as you I have no issue. I really don't understand what is happening here 😅 |
Finally found the issue! merging!! |
5f4d297
into
meilisearch:bump-meilisearch-v1.9.0
Pull Request
Related issue
Fixes #1665
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!