Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request timeout #1554

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Add request timeout #1554

merged 5 commits into from
Sep 27, 2023

Conversation

amit-ksh
Copy link
Contributor

@amit-ksh amit-ksh commented Aug 3, 2023

Pull Request

Related issue

Fixes #716

What does this PR do?

  • Added the timeout property to the config.
  • Added a test to search.test.ts which cancels the timeout after 1 millisecond.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

bidoubiwa
bidoubiwa reviewed Aug 29, 2023
View reviewed changes
src/http-requests.ts Outdated Show resolved Hide resolved
src/http-requests.ts Outdated Show resolved Hide resolved
amit-ksh and others added 2 commits August 29, 2023 20:09
@amit-ksh @bidoubiwa
Rename timeout variable
f354094 
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
@amit-ksh @bidoubiwa
Update src/http-requests.ts
c020e95 
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
@amit-ksh
Copy link
Contributor Author

Hey @bidoubiwa, I'll fix the code and test tomorrow since renaming the variable caused the test to fail.

bidoubiwa
bidoubiwa reviewed Aug 30, 2023
View reviewed changes
src/http-requests.ts Outdated Show resolved Hide resolved
bidoubiwa
bidoubiwa approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@bidoubiwa
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 27, 2023

Build succeeded:

@amit-ksh amit-ksh closed this Sep 27, 2023
@meili-bors meili-bors bot merged commit 4af90a9 into meilisearch:main Sep 27, 2023
6 checks passed
@bidoubiwa bidoubiwa added the enhancement New feature or request label Sep 27, 2023
@amit-ksh amit-ksh deleted the feat/request-timeout branch June 23, 2024 11:04
@WontonSam WontonSam mentioned this pull request Jul 26, 2024
Open
@ramzimalhas ramzimalhas mentioned this pull request Aug 22, 2024
Open
@ferdi05 ferdi05 mentioned this pull request Sep 1, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The user should be able to change the requests timeout
2 participants
@amit-ksh @bidoubiwa