Skip to content

Feature prototype: pagination feature compatibility #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Jul 20, 2022

We would like users to be able to test out a new feature before adding it to Meilisearch.

With this PR users are now able to use the following search query parameters:

  • page
  • hitsPerPage

and receive in their search response the following fields:

  • page
  • hitsPerPage
  • totalPages

The following response fields are now optional:

  • offset
  • limit
  • estimatedTotalHits

See related issue
See related discussion

@curquiza and @ManyTheFish I put you as a reviewer but please only review types.ts as it covers the changes in parameters and response fields. It is to ensure I correctly followed the specs.

@bidoubiwa bidoubiwa changed the base branch from main to create_new_beta_handling July 20, 2022 12:40
@bidoubiwa bidoubiwa added the breaking-change The related changes are breaking for the users label Jul 20, 2022
Base automatically changed from create_new_beta_handling to main July 21, 2022 09:31
@bidoubiwa bidoubiwa requested a review from brunoocasali July 21, 2022 11:53
curquiza
curquiza previously approved these changes Jul 21, 2022
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand well and ? next to the parameter means the parameter is optional, LGTM according to the prototype 👌

ManyTheFish
ManyTheFish previously approved these changes Jul 25, 2022
@bidoubiwa bidoubiwa added the beta Changes not meant to be merged on main label Jul 25, 2022
brunoocasali
brunoocasali previously approved these changes Jul 25, 2022
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bidoubiwa bidoubiwa changed the title Add beta pagination feature compatibility Feature prototype: pagination feature compatibility Jul 27, 2022
@bidoubiwa
Copy link
Contributor Author

closed at his has been added in v0.30.0

@bidoubiwa bidoubiwa closed this Jan 18, 2023
@bidoubiwa bidoubiwa deleted the pagination-beta branch March 15, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Changes not meant to be merged on main breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants