Add a custom user-agent for Node users. #1437
Labels
enhancement
New feature or request
Comments
|
Hi @brunoocasali can you let me know if this is still be done? |
|
Yes, go ahead as far as I remember we still have the same user agent for both! |
3 tasks
meili-bors bot
added a commit
that referenced
this issue
Oct 31, 2023
1595: refactor: update clients to have different user agents r=brunoocasali a=Botseer # Pull Request ## Related issue Fixes #1437 ## What does this PR do? The users agents for BrowserClient and NodeClient have been differentiated as per the issue for better metrics. As for the code changes, I have made the change such that the necessary user agents are provided while constructing the respective client itself. Therefore there is no need to handle user agents in the `http-request` file. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Botseer <homeu99@gmail.com>
|
#1739 makes it so there is only one universal client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The idea is to send a new
Meilisearch Node (v0.0.0)alongside the current user agents when the user requests on the backend side.I think there are valuable insights if we could differentiate those metrics.
The text was updated successfully, but these errors were encountered: