Support experimental manager #572

A7bari · 2024-08-23T20:02:46Z

Pull Request

Related issue

Fixes #571

What does this PR do?

Introduce a new ExperimentalFeatures struct and methods to support the experimental features in the Meilisearch client. Users can enable or disable specific experimental features (vector store, logs route, and metrics).

PR checklist

Please check if your PR fulfills the following requirements:

Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
Have you read the contributing guidelines?
Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

The code changes introduce a new `ExperimentalFeatures` struct and methods to support experimental features

Ja7ad · 2024-08-24T19:10:00Z

@Ahbari-M Just one things you need do, please transcode get and update curl to golang example on file https://github.com/meilisearch/meilisearch-go/blob/main/.code-samples.meilisearch.yaml.

https://github.com/meilisearch/documentation/blob/04f26a35771305378ed0a506f4d60ef06d07bd7e/.code-samples.meilisearch.yaml#L1074-L1083

get_experimental_features_1: |-
  curl \
    -X GET 'http://localhost:7700/experimental-features/'
update_experimental_features_1: |-
  curl \
    -X PATCH 'http://localhost:7700/experimental-features/' \
    -H 'Content-Type: application/json'  \
    --data-binary '{
      "metrics": true
    }'

… file

568: Add Embedder.URL r=brunoocasali a=polyfloyd # Pull Request ## What does this PR do? Partial fix for meilisearch#576 The documentation for the Ollama Embedder states that there is an `url` field that can be used to specify how Ollama can be reached. However, this field is not present yet in this client library. See: https://www.meilisearch.com/docs/learn/experimental/vector_search#generate-auto-embeddings ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Co-authored-by: polyfloyd <floyd@polyfloyd.net>

The merge-base changed after approval.

Ja7ad · 2024-09-29T19:38:11Z

bors merge

572: Support experimental manager r=Ja7ad a=A7bari # Pull Request ## Related issue Fixes #571 ## What does this PR do? Introduce a new `ExperimentalFeatures` struct and methods to support the experimental features in the Meilisearch client. Users can enable or disable specific experimental features (vector store, logs route, and metrics). ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: polyfloyd <floyd@polyfloyd.net> Co-authored-by: Javad <ja7ad@live.com> Co-authored-by: Ahbari-M <mohammed.ahbari@usmba.ac.ma> Co-authored-by: meili-bors[bot] <89034592+meili-bors[bot]@users.noreply.github.com> Co-authored-by: Javad Rajabzadeh <ja7ad@live.com>

meili-bors · 2024-09-29T19:40:14Z

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"}

Ja7ad · 2024-09-29T19:42:09Z

bors merge

572: Support experimental manager r=Ja7ad a=A7bari # Pull Request ## Related issue Fixes #571 ## What does this PR do? Introduce a new `ExperimentalFeatures` struct and methods to support the experimental features in the Meilisearch client. Users can enable or disable specific experimental features (vector store, logs route, and metrics). ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: polyfloyd <floyd@polyfloyd.net> Co-authored-by: Javad <ja7ad@live.com> Co-authored-by: Ahbari-M <mohammed.ahbari@usmba.ac.ma> Co-authored-by: meili-bors[bot] <89034592+meili-bors[bot]@users.noreply.github.com> Co-authored-by: Javad Rajabzadeh <ja7ad@live.com>

The merge-base changed after approval.

meili-bors · 2024-09-29T19:44:07Z

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"}

curquiza

bors merge

The merge-base changed after approval.

572: Support experimental manager r=curquiza a=A7bari # Pull Request ## Related issue Fixes #571 ## What does this PR do? Introduce a new `ExperimentalFeatures` struct and methods to support the experimental features in the Meilisearch client. Users can enable or disable specific experimental features (vector store, logs route, and metrics). ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: polyfloyd <floyd@polyfloyd.net> Co-authored-by: Javad <ja7ad@live.com> Co-authored-by: Ahbari-M <mohammed.ahbari@usmba.ac.ma> Co-authored-by: meili-bors[bot] <89034592+meili-bors[bot]@users.noreply.github.com> Co-authored-by: Javad Rajabzadeh <ja7ad@live.com>

meili-bors · 2024-09-30T13:27:19Z

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"}

curquiza · 2024-09-30T14:54:17Z

bors try

meili-bors · 2024-09-30T14:56:04Z

try

Build succeeded:

curquiza · 2024-09-30T15:50:43Z

~~I merge by hand because I don't understand~~

I want to get the answer of @A7bari first

The merge-base changed after approval.

curquiza · 2024-09-30T15:51:51Z

That's sooooo weird @A7bari do you know why your profile reject the review? is it the first time?
It's not a problem with bors here

A7bari · 2024-10-01T12:40:47Z

Hello @curquiza, I have no idea why it happened.
also, I changed my GitHub's username recently. Do you think that's why?

curquiza · 2024-10-01T15:17:56Z

No I don't think so, really @A7bari

I'm merging by hand

The merge-base changed after approval.

584: Update version for the next release (v0.29.0) r=brunoocasali a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-go to a new version: "v0.29.0" --- Changelogs 👇 --- ## ⚠️ Breaking changes (experimental feature) * `embedder` is now mandatory everywhere - Ensure compatibility with [Meilisearch v1.11](https://github.com/meilisearch/meilisearch/releases/tag/v1.11.0) by `@/Kerollmops` ## 🚀 Enhancements * Add Embedder.URL (#568) `@/polyfloyd` * Add multi-search federation (#563) `@/polyfloyd` * Feat support content encoding (#570) `@/Ja7ad` * Support experimental manager (#572) `@/A7bari` * Feat Language settings & search parameter (#580) `@J/a7ad` * Feat support retry pattern on status code 502, 503, 504 (#581) `@/Ja7ad` Thanks again to `@/A7bari,` `@/Ja7ad,` `@/Kerollmops` and `@/polyfloyd!` 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>

polyfloyd and others added 12 commits August 22, 2024 14:41

Add Embedder.URL

9ffd104

feat: add gzip and deflate encoding

5eba25b

feat: client support content encoding for body and response

9a6b1f6

feat: add option for enable content encoding

db521a0

feat: add content encoding and compress level type

59cc80d

feat: add content encoding on constructor

d5a44d2

fix: header set for user agent

d3de4f1

feat: add brotli encoding

97e6d77

fix: support request and response encoding same type encoding opt

b8a9f5a

fix: add unit test for options

ed267b4

feat: Add experimental features support

238a029

The code changes introduce a new `ExperimentalFeatures` struct and methods to support experimental features

generating type marshalers and unmarshalers

04aba93

Ja7ad approved these changes Aug 24, 2024

View reviewed changes

Ja7ad added 2 commits August 24, 2024 09:45

add: zero allocation copy for writer

d9713ec

add: unit test for zero allocation copy

7cb77b2

feat: transcode get and update curl to golang example on code-samples…

c521579

… file

A7bari requested a review from Ja7ad August 24, 2024 23:01

Ja7ad previously approved these changes Aug 25, 2024

View reviewed changes

Ja7ad and others added 11 commits August 25, 2024 22:26

fix: remove encoding option on internal request object

55bee99

chore: add unit test for content encoding

578ea94

fix: used built-in flate package

24cbcb4

fix: used built-in gzip package

d868fd3

fix: data race on test zero alloc

e08d216

fix: test case issue

14c606d

fix: add some test stage for improve coverage

227dbe2

fix: remove brotli test stage

6c56bf0

fix: add encoder for decoing encoded internal error

a4da3e4

Merge branch 'main' into feat/content-encoding

617e53b

Ja7ad previously approved these changes Sep 29, 2024

View reviewed changes

Ja7ad self-requested a review September 29, 2024 19:41

Ja7ad previously approved these changes Sep 29, 2024

View reviewed changes

curquiza previously approved these changes Sep 30, 2024

View reviewed changes

meili-bors bot added a commit that referenced this pull request Sep 30, 2024

Try #572:

77e01c6

curquiza previously approved these changes Sep 30, 2024

View reviewed changes

curquiza previously approved these changes Oct 1, 2024

View reviewed changes

curquiza merged commit 1cd56a5 into meilisearch:main Oct 1, 2024
5 of 6 checks passed

curquiza added the enhancement New feature or request label Oct 1, 2024

curquiza mentioned this pull request Oct 11, 2024

Update version for the next release (v0.29.0) #584

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support experimental manager #572

Support experimental manager #572

A7bari commented Aug 23, 2024

Ja7ad commented Aug 24, 2024 •

edited

Loading

Ja7ad commented Sep 29, 2024

meili-bors bot commented Sep 29, 2024

Ja7ad commented Sep 29, 2024

meili-bors bot commented Sep 29, 2024

curquiza left a comment

meili-bors bot commented Sep 30, 2024

curquiza commented Sep 30, 2024

meili-bors bot commented Sep 30, 2024

curquiza commented Sep 30, 2024 •

edited

Loading

curquiza commented Sep 30, 2024

A7bari commented Oct 1, 2024

curquiza commented Oct 1, 2024

Support experimental manager #572

Support experimental manager #572

Conversation

A7bari commented Aug 23, 2024

Pull Request

Related issue

What does this PR do?

PR checklist

Ja7ad commented Aug 24, 2024 • edited Loading

Ja7ad commented Sep 29, 2024

meili-bors bot commented Sep 29, 2024

Ja7ad commented Sep 29, 2024

meili-bors bot commented Sep 29, 2024

curquiza left a comment

Choose a reason for hiding this comment

meili-bors bot commented Sep 30, 2024

curquiza commented Sep 30, 2024

meili-bors bot commented Sep 30, 2024

try

curquiza commented Sep 30, 2024 • edited Loading

curquiza commented Sep 30, 2024

A7bari commented Oct 1, 2024

curquiza commented Oct 1, 2024

Ja7ad commented Aug 24, 2024 •

edited

Loading

curquiza commented Sep 30, 2024 •

edited

Loading