Skip to content

v1: Database size limits #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 2, 2023
Merged

v1: Database size limits #2118

merged 5 commits into from
Feb 2, 2023

Conversation

@guimachiavelli
Copy link
Member

@guimachiavelli guimachiavelli commented Jan 17, 2023

Closes #2077

@guimachiavelli guimachiavelli linked an issue Jan 17, 2023 that may be closed by this pull request
v1.0: update telemetry table #2078
Closed
@guimachiavelli guimachiavelli changed the base branch from main to v1.0 January 17, 2023 17:16
@guimachiavelli guimachiavelli changed the title v1: database size limits v1: Database size limits Jan 18, 2023
@guimachiavelli guimachiavelli marked this pull request as ready for review January 18, 2023 11:38
guimachiavelli
guimachiavelli commented Jan 18, 2023
View reviewed changes
dureuill
dureuill requested changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, it looks good to me, just a single comment (see inline comment).

dureuill
dureuill approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

maryamsulemani97
maryamsulemani97 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@maryamsulemani97 maryamsulemani97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦅

@guimachiavelli @maryamsulemani97
Update learn/advanced/known_limitations.md
fb32b78 
Co-authored-by: Maryam <90181761+maryamsulemani97@users.noreply.github.com>
@guimachiavelli guimachiavelli added this to the v1.0 milestone Jan 30, 2023
@guimachiavelli
Copy link
Member Author

guimachiavelli commented Feb 2, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 2, 2023

Build succeeded:

@bors bors bot merged commit c5dc37c into v1.0 Feb 2, 2023
@bors bors bot deleted the v1-index-size-limits branch February 2, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dureuill dureuill dureuill approved these changes

+1 more reviewer

@maryamsulemani97 maryamsulemani97 maryamsulemani97 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0

Development

Successfully merging this pull request may close these issues.

v1.0: update telemetry table v1.0: Remove --max-index-size and --max-task-db configuration options

4 participants

@guimachiavelli @dureuill @maryamsulemani97