-
Notifications
You must be signed in to change notification settings - Fork 269
v1.0: update to add * for date filters in task api
#2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
guimachiavelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the added wildcard explanation makes sense.
For example: we say beforeEnqueuedAt=* returns all tasks enqueued before the specified date. However, there is no specified date—the value is not a date, but *.
The spec states:
when
beforeEnqueuedAtquery parameter is not set or set to*, all task are selected.
Which, AFAIU, would mean that beforeEnqueuedAt=* is functionally the same as not adding beforeEnqueuedAt.
Am I missing something? Or would a better way of explaining the wildcard default be something like:
*(all enqueued tasks)
I updated it to "all tasks" as the spec says: "By default, when |
guimachiavelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need to propagate the "all tasks" change to the response fields? (lines 360-363 and 422-427)
guimachiavelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📟
|
bors merge |
|
Build succeeded:
|
closes #2109