Skip to content

Conversation

@maryamsulemani97
Copy link
Contributor

closes #2109

@maryamsulemani97 maryamsulemani97 added this to the v1.0 milestone Jan 16, 2023
@maryamsulemani97 maryamsulemani97 linked an issue Jan 16, 2023 that may be closed by this pull request
2 tasks
@maryamsulemani97 maryamsulemani97 marked this pull request as ready for review January 16, 2023 12:04
@guimachiavelli guimachiavelli self-assigned this Jan 18, 2023
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the added wildcard explanation makes sense.

For example: we say beforeEnqueuedAt=* returns all tasks enqueued before the specified date. However, there is no specified date—the value is not a date, but *.

The spec states:

when beforeEnqueuedAt query parameter is not set or set to *, all task are selected.

Which, AFAIU, would mean that beforeEnqueuedAt=* is functionally the same as not adding beforeEnqueuedAt.

Am I missing something? Or would a better way of explaining the wildcard default be something like:

* (all enqueued tasks)

@maryamsulemani97
Copy link
Contributor Author

Or would a better way of explaining the wildcard default be something like:

  • (all enqueued tasks)

I updated it to "all tasks" as the spec says: "By default, when beforeEnqueuedAt query parameter is not set or set to *, all task are selected."

Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to propagate the "all tasks" change to the response fields? (lines 360-363 and 422-427)

Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📟

@guimachiavelli
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 2, 2023

Build succeeded:

@bors bors bot merged commit 157a893 into v1.0 Feb 2, 2023
@bors bors bot deleted the v1.0--update-to-add---for-date-filters-in-task-API branch February 2, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.0: update to add * for date filters in task API

4 participants