v1.0: Primary key inference #2104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dureuill
requested changes
Jan 16, 2023
Contributor
dureuill
left a comment
dureuill
left a comment
There was a problem hiding this comment.
Thanks for the PR! I have one technical comment about adding id to a field in the case where multiple candidates are found (see inline comments)
dureuill
requested changes
Jan 17, 2023
Contributor
dureuill
left a comment
dureuill
left a comment
There was a problem hiding this comment.
I have further comments, I'm sorry about the second round of review, the error messages somehow escaped me the first time around.
Co-authored-by: Louis Dureuil <louis.dureuil@gmail.com>
dureuill
approved these changes
Jan 17, 2023
Contributor
dureuill
left a comment
dureuill
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you for the PR 👍
dichotommy
suggested changes
Jan 24, 2023
Co-authored-by: Tommy <68053732+dichotommy@users.noreply.github.com>
Contributor
Author
|
bors merge |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2075