Skip to content

v1.0: Reject master keys less than 16 bytes #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 2, 2023
Merged

v1.0: Reject master keys less than 16 bytes #2103

merged 6 commits into from
Feb 2, 2023

Conversation

@maryamsulemani97
Copy link
Contributor

@maryamsulemani97 maryamsulemani97 commented Jan 11, 2023

closes #2069

@maryamsulemani97 maryamsulemani97 linked an issue Jan 11, 2023 that may be closed by this pull request
v1.0: Reject master keys with a size lower than 16 bytes #2069
Closed
2 tasks
@maryamsulemani97 maryamsulemani97 marked this pull request as ready for review January 16, 2023 10:57
dureuill
dureuill approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @maryamsulemani97.

@dichotommy
Copy link
Contributor

dichotommy commented Jan 17, 2023

Hey @maryamsulemani97 . Once #2122 is merged, would you please update the master key section of the instance options page to specify that it must be 16 bytes? To be honest, this should have been done already.

Adding it to the "expected value" should be sufficient. Thanks 🙏🏻

@maryamsulemani97
Copy link
Contributor Author

maryamsulemani97 commented Jan 18, 2023

Hi @dureuill
Sorry for asking for another review. I missed the part on autogenerated master keys before.
Thanks 🙏

dureuill
dureuill approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, @maryamsulemani97!

IMO it was also OK not to mention the autogeneration in the docs, which is why I approved the previous version.

Note that we're currently discussing removing the export MEILI_MASTER_KEY=<autogenerated_key> instruction in favor of directing the user to the --master-key command line flag. You can find the relevant discussion in the specification PR.

@guimachiavelli guimachiavelli self-assigned this Jan 18, 2023
guimachiavelli
guimachiavelli requested changes Jan 19, 2023
View reviewed changes
maryamsulemani97 and others added 2 commits January 19, 2023 18:40
@maryamsulemani97 @guimachiavelli
Apply suggestions from code review
62770a7 
Co-authored-by: gui machiavelli <gui@meilisearch.com>
@maryamsulemani97
update based on review
23b528c
guimachiavelli
guimachiavelli approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧋

@guimachiavelli guimachiavelli added this to the v1.0 milestone Jan 30, 2023
@guimachiavelli
Copy link
Member

guimachiavelli commented Feb 2, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 2, 2023

Build succeeded:

@bors bors bot merged commit 4707e94 into v1.0 Feb 2, 2023
@bors bors bot deleted the v1.0--Reject-master-keys-with-a-size-lower-than-16-bytes branch February 2, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guimachiavelli guimachiavelli guimachiavelli approved these changes

@dureuill dureuill dureuill approved these changes

Assignees

@guimachiavelli guimachiavelli

Labels

None yet

Projects

None yet

Milestone

v1.0

Development

Successfully merging this pull request may close these issues.

v1.0: Reject master keys with a size lower than 16 bytes

5 participants

@maryamsulemani97 @dichotommy @guimachiavelli @dureuill