Skip to content

Conversation

@maryamsulemani97
Copy link
Contributor

closes #2068

Since users no longer get an internal error, I removed the "Large datasets and internal errors" limitation

@maryamsulemani97 maryamsulemani97 changed the title too_many_open_files error v1.0: too_many_open_files error Jan 11, 2023
@maryamsulemani97 maryamsulemani97 linked an issue Jan 11, 2023 that may be closed by this pull request
1 task
@maryamsulemani97 maryamsulemani97 marked this pull request as ready for review January 16, 2023 10:23
@curquiza
Copy link
Member

@maryamsulemani97 can you make @irevoire as reviewer since he's the one who implemented it? 😇
#2068 (comment)

@maryamsulemani97
Copy link
Contributor Author

My bad, thanks @curquiza! 🙏

@maryamsulemani97 maryamsulemani97 requested review from irevoire and removed request for curquiza January 16, 2023 10:38
Copy link
Contributor

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guimachiavelli guimachiavelli self-assigned this Jan 18, 2023
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's weird that all our error descriptions are like two sentences and then this one is a proper chunk of (hopefully) helpful content.

@maryamsulemani97
Copy link
Contributor Author

I wonder if it's weird that all our error descriptions are like two sentences and then this one is a proper chunk of (hopefully) helpful content.

Agreed. Compared to most errors, we don't have any other section of the docs we can refer them to. So we add whatever can help here

@guimachiavelli guimachiavelli added this to the v1.0 milestone Jan 30, 2023
@maryamsulemani97
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 2, 2023

@bors bors bot merged commit 2f9f3df into v1.0 Feb 2, 2023
@bors bors bot deleted the v1.0--New-error--too_many_open_files branch February 2, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.0: New error: too_many_open_files

5 participants