Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vuepress full-text search ultimate version-algolia's open source implementation meilisearch full access guide #36

Merged
merged 5 commits into from
Apr 13, 2023

Conversation

eryajf
Copy link
Contributor

@eryajf eryajf commented Mar 7, 2023

Pull Request

Related issue

meilisearch/meilisearch#3535

What does this PR do?

add a Community Blog Posts

Because the original text of this article is in Chinese, the name of the resource is also in Chinese, while the following comments are annotated in English. I hope it's not against the rules.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

README.md Outdated
@@ -219,6 +219,7 @@ Please take a look at the [Contribution Guidelines](https://github.com/meilisear

### Community Blog Posts
* [Meilisearch: A Minimalist Full-Text Search Engine](https://tech.marksblogg.com/meilisearch-full-text-search.html)
* :cn: [Vuepress全文搜索终极版-algolia的开源实现meilisearch全接入指南](https://wiki.eryajf.net/pages/dfc792/) - Vuepress full-text search ultimate version-algolia's open source implementation meilisearch full access guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eryajf thanks for your contribution.
I must say that I find it hard to understand the title/description. We don't think ourselves as an implementation of Algolia, but as an alternative. So I find it quite confusing.
Would you ke ok to change it somehow? Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md Outdated
@@ -219,7 +219,7 @@ Please take a look at the [Contribution Guidelines](https://github.com/meilisear

### Community Blog Posts
* [Meilisearch: A Minimalist Full-Text Search Engine](https://tech.marksblogg.com/meilisearch-full-text-search.html)
* :cn: [Vuepress全文搜索终极版-algolia的开源实现meilisearch全接入指南](https://wiki.eryajf.net/pages/dfc792/) - Vuepress full-text search ultimate version-algolia's open source implementation meilisearch full access guide
* :cn: [Vuepress全文搜索终极版-基于开源搜索引擎meilisearch的全接入指南](https://wiki.eryajf.net/pages/dfc792/) - Vuepress Full Text Search Ultimate Edition-Full Access Guide Based on Open Source Search Engine meilisearch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I think using Full this often is a bit overkill.
How about A guide on Meilisearch-based full-text search in Vuepress? I could be super wrong on your intent though, I must say I don't read Chinese and I could be wrong about what's in the guide

README.md Outdated
@@ -219,7 +219,7 @@ Please take a look at the [Contribution Guidelines](https://github.com/meilisear

### Community Blog Posts
* [Meilisearch: A Minimalist Full-Text Search Engine](https://tech.marksblogg.com/meilisearch-full-text-search.html)
* :cn: [Vuepress全文搜索终极版-基于开源搜索引擎meilisearch的全接入指南](https://wiki.eryajf.net/pages/dfc792/) - Vuepress Full Text Search Ultimate Edition-Full Access Guide Based on Open Source Search Engine meilisearch
* :cn: [Vuepress全文搜索终极版-基于开源搜索引擎meilisearch的接入配置指南](https://wiki.eryajf.net/pages/dfc792/) - A guide on Meilisearch-based full-text search in Vuepress
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I'm sorry for being annoying, but I just thought that as a guide it should probably belong to the Community guides section? If you agree, I'll make the changes, you've already done a lot :)

Move this contribution to the community section
@ferdi05 ferdi05 merged commit 92eaa57 into meilisearch:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants