Introduce the Writer::prepare_for_conversion method
#151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are we duplicating this code both in arroy and hannoy? |
|
@irevoire, the code is slightly different, especially around the |
irevoire
approved these changes
Aug 21, 2025
Kerollmops
force-pushed
the
prepare-for-conversion-from-hannoy
branch
from
2b8d563 to
9019306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is akin to nnethercott/hannoy#42 and introduces a way to convert a hannoy database into an arroy one. We plan to add an (experimental) setting in the index settings of Meilisearch that permits users to switch between Vector Store backends.