fix mypy errors #59
fix mypy errors #59
Conversation
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
| def active(self) -> bool: | ||
| """True if agent loop started, False otherwise.""" | ||
| return self._loop.active | ||
| return cast(bool, self._loop.active) |
There was a problem hiding this comment.
There is an issue here. We seem to be using loop.active and loop._active. I think we might have a bug in that logic
There was a problem hiding this comment.
Could you point me to an instance of loop._active? I only see _loop.active
There was a problem hiding this comment.
nvm, i'm wrong. i was looking into bidi agent loop code, but i missed something.
There was a problem hiding this comment.
though this fix still feels a bit unnecessary to me, because _loop.active is a property defined as bool already. anyway, no blockers here
There was a problem hiding this comment.
yeah that fix is outdated. There was a discrepancy in errors when I was running mypy directly vs hatch run prepare. Removed the fix above
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
| class _BidiTextOutput(BidiOutput): | ||
| """Handle text output from bidi agent.""" | ||
|
|
||
| async def start(self) -> None: |
There was a problem hiding this comment.
Did mypy complain about this? We use a Protocol for BidiOutput with default implementations of start and stop and so explicitly adding start and stop here should not be necessary.
There was a problem hiding this comment.
yeah mypy was complaining about it
There was a problem hiding this comment.
We should fix that. It doesn't have to block this PR, but the protocol can be setup not to require these methods.
mehtarac
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Description
This PR fixes mypy errors
Related Issues
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.