Skip to content

Visual assets appear in plugin#495

Merged
talonchandler merged 3 commits intomainfrom
ship-assets
Sep 13, 2025
Merged

Visual assets appear in plugin#495
talonchandler merged 3 commits intomainfrom
ship-assets

Conversation

@talonchandler
Copy link
Collaborator

Fixes #494.

#461 broke the links, and #480 does not ship these assets. This PR fixes both issues.


[tool.setuptools.package-data]
"*" = ["*.yaml"]
"*" = ["*.yaml", "assets/*png"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srivarra is this the best way to do this?

Copy link
Contributor

@srivarra srivarra Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@talonchandler After doing some digging around, yeah is the most straightforward way to do it.

Or if internet connection is expected, you could grab the image from the https://raw.githubusercontent.com/mehta-lab/waveorder/8e75f7ffe0a9751b4f8f105e01d3092e0f0a2194/waveorder/assets/HSV_legend.png and have it download when napari loads, without having to throw it into the wheel.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think these are small enough that I'm fine shipping with the wheel

@talonchandler talonchandler changed the title Visual assets appear in plugin. Visual assets appear in plugin Sep 12, 2025
Copy link
Contributor

@srivarra srivarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you not need the HSV_legend.png in the docs itself?


[tool.setuptools.package-data]
"*" = ["*.yaml"]
"*" = ["*.yaml", "assets/*png"]
Copy link
Contributor

@srivarra srivarra Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@talonchandler After doing some digging around, yeah is the most straightforward way to do it.

Or if internet connection is expected, you could grab the image from the https://raw.githubusercontent.com/mehta-lab/waveorder/8e75f7ffe0a9751b4f8f105e01d3092e0f0a2194/waveorder/assets/HSV_legend.png and have it download when napari loads, without having to throw it into the wheel.

@talonchandler
Copy link
Collaborator Author

Do you not need the HSV_legend.png in the docs itself?

No...we have some screenshots that include this, but there's no need to import it by itself.

@talonchandler talonchandler merged commit fcfd625 into main Sep 13, 2025
11 checks passed
@talonchandler talonchandler deleted the ship-assets branch September 13, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin's visual assets do not appear

2 participants