Skip to content

Package layout fix#489

Merged
talonchandler merged 1 commit intomainfrom
fix-setuptools
Sep 10, 2025
Merged

Package layout fix#489
talonchandler merged 1 commit intomainfrom
fix-setuptools

Conversation

@talonchandler
Copy link
Collaborator

@talonchandler talonchandler commented Sep 10, 2025

Fixes a installation problem introduced by #480.

Specifying [tool.setuptools.packages.find]; where = ["waveorder"] looks for a package named waveorder inside waveorder which was one too deep...leading to import issues.

[tool.setuptools.packages.find]
where = ["waveorder"]
@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.20%. Comparing base (34cdafb) to head (a060440).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   46.13%   46.20%   +0.07%     
==========================================
  Files          50       50              
  Lines       10342    10367      +25     
==========================================
+ Hits         4771     4790      +19     
- Misses       5571     5577       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@srivarra srivarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very odd that GHA tests passed for that one, but locally just trying to use the waveorder cli and napari plugins failed.

@talonchandler talonchandler merged commit 96099fc into main Sep 10, 2025
13 checks passed
@srivarra
Copy link
Contributor

As an aside, I did a quick test for converting the package from a flat-layout to a src-layout and it worked flawlessly (tests, opening napari with waveorder, etc...). So if at any point you'd like to move to that layout structure it'll be smooth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants