Update README and LICENSE #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few things were not rendered as headings and there was an unfinished merge in the license. I think fig is so deprecated it should no longer be mentiioned.
Update to postgres 10, docker-compose 3 and alpine 3.7. Set the exposed port to 5000 to avoid confusion. Make service names resemble docker tutorials.
|
Hi @JarnoRFB thanks for the feedback! Let me take a look at the changes you've suggested. Apologies for the delay! |
|
Ok what I'm going to do is probably not the best practice but I'm going to merge your changes. The base image that this project uses is on DockerHub. And I'll have to update that image for anything to take effect in this repo. Once I'm at my home computer I'll test it. If it fails I'll roll back the changes. Thanks for the corrections! |
|
Maybe configuring an automated build for the base images makes sense? https://docs.docker.com/docker-hub/builds/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things were not rendered as headings and there was an unfinished
merge in the license. I think fig is so deprecated it should no longer
be mentiioned.